Skip to content

[CodeStyle][Typos][S-[21-25]] Fix typos(shoud,shoule,Singal,simular,Similiar,Simle,signle) - #70936

Merged
SigureMo merged 1 commit into
PaddlePaddle:developfrom
enkilee:typo-s21
Jan 23, 2025
Merged

SigureMo merged 1 commit into
PaddlePaddle:developfrom
enkilee:typo-s21

Conversation

@enkilee

@enkilee enkilee commented Jan 22, 2025

Copy link
Copy Markdown
Collaborator

PR Category

User Experience

PR Types

Devs

Description

fixed:
shoud,shoule,Singal,simular,Similiar,Simle,signle

@paddle-bot paddle-bot Bot added the contributor External developers label Jan 22, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 23, 2025

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Comment thread _typos.toml
simular = 'simular'
Simle = 'Simle'
signle = 'signle'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这咋多出来一行,后面删掉

common::errors::InvalidArgument(
"The first dimension size of Input(Index) shoud be no greater than "
"The first dimension size of Input(Index) should be no greater "
"than "

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format 后这行只有一个词不太好看,后面可以和其他行拼在一起

@SigureMo
SigureMo merged commit dbd9d0f into PaddlePaddle:develop Jan 23, 2025
@SigureMo

Copy link
Copy Markdown
Collaborator
❯ typos
error: `shoule` should be `should`
  --> ./paddle/fluid/inference/tensorrt/plugin/preln_residual_bias_plugin.cu:725:38
    |
725 |           "The input of swish plugin shoule not be nullptr."));
    |                                      ^^^^^^
    |
error: `payed` should be `paid`
  --> ./paddle/fluid/distributed/ps/thirdparty/round_robin.h:1582:17
     |
1582 |   // penalty is payed at the first insert, and not before. Lookup of this empty
     |                 ^^^^^
     |

@enkilee 还有一些漏了的,版本不对还是?现在 typos 是 1.29.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants